feat: sshnp gui core MVP #467
Conversation
…ackend methods and show appropriate properties on the respective screens
feat: SSHNP Params Controller
| @@ -21,22 +21,18 @@ Future<AtClient> createAtClientCli({ | |||
| pathBase += '$pathExtension${Platform.pathSeparator}'; | |||
There was a problem hiding this comment.
Changed how paths are normalized in this file
| @@ -3,6 +3,7 @@ import 'dart:io'; | |||
| import 'package:at_chops/at_chops.dart'; | |||
| import 'package:at_client/at_client.dart'; | |||
| import 'package:at_utils/at_utils.dart'; | |||
| import 'package:path/path.dart' as path; | |||
|
|
|||
There was a problem hiding this comment.
file normalization in this file too
| @@ -195,3 +214,47 @@ class SSHNPArg { | |||
| return 'SSHNPArg{format: $format, name: $name, abbr: $abbr, help: $help, mandatory: $mandatory, defaultsTo: $defaultsTo, type: $type}'; | |||
| } | |||
| } | |||
|
|
|||
| ArgParser createArgParser({ | |||
There was a problem hiding this comment.
Moved this from SSHNPParams so that SSHNPParams would be more focused in intention
| aliases: ['ls'], | ||
| negatable: false, | ||
| help: 'List available devices', | ||
| commandLineOnly: true, |
There was a problem hiding this comment.
These were injected with an if, now using commandLineOnly: true to be injected to the command line
| @@ -198,7 +198,16 @@ class SSHNPImpl implements SSHNP { | |||
|
|
|||
There was a problem hiding this comment.
path normalization, and catching errors in this file
| _doneCompleter.complete(); | ||
| break; | ||
| case SupportedSshClient.pureDart: | ||
| (success, errorMessage) = await directSshViaSSHClient(); | ||
| (success, errorMessage, client) = await directSshViaSSHClient(); |
There was a problem hiding this comment.
passing through client and process so they can be added to the SSHNPResult
| @@ -6,34 +6,35 @@ class SSHNPParams { | |||
| /// Since there are multiple sources for these values, we cannot validate | |||
There was a problem hiding this comment.
remove late calls, reorder functions
| @@ -2,12 +2,14 @@ part of 'sshnp.dart'; | |||
|
|
|||
There was a problem hiding this comment.
Updated the SSHNPResult covariants to be compatible with the GUI
| @@ -17,17 +17,12 @@ Future<void> cleanUpAfterReverseSsh(SSHNP sshnp) async { | |||
| if (homeDirectory == null) { | |||
| return; | |||
XavierChanth
changed the title
- What I did
- How I did it
- How to verify it
- Description for the changelog
feat: sshnp gui core MVP